Open
Conversation
Fixes ProgressPlanner#16 When the HTML-to-Markdown converter throws, the code now falls back to wp_strip_all_tags() plus html_entity_decode() instead of causing a fatal error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
When the HTML-to-Markdown converter throws, the code now falls back to
wp_strip_all_tags()plushtml_entity_decode()instead of causing a fatal error.Context
When a post or page contains HTML that causes the League HTML-to-Markdown converter to throw (e.g., malformed or edge-case markup), the plugin previously did not catch the exception. This resulted in a PHP fatal error and a 500 response instead of returning markdown or a safe fallback. This PR adds a try/catch around the conversion call and uses a plain-text fallback so
.mdURLs always return content instead of failing.Summary
This PR can be summarized in the following changelog entry:
wp_strip_all_tags()andhtml_entity_decode()instead of causing a fatal error. Ensures.mdURLs always return output.Relevant technical choices:
convert(): Wraps the converter call in a\Throwablecatch so bothExceptionandErrorare handled.wp_strip_all_tags()for the HTML → plain text fallback andhtml_entity_decode()to decode entities, mirroring the behavior used for code blocks elsewhere in the renderer.Test instructions
.mdURL (e.g.https://yoursite.com/post-slug.md).Relevant test scenarios
UI changes
Documentation
Quality assurance
Fixes #16