Skip to content

refactor: simplify plugin activation and remove duplicate rewrite registration #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdevalk wants to merge 1 commit into from
Closed

refactor: simplify plugin activation and remove duplicate rewrite registration #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ private function __construct() {
* @return void
*/
public static function activate(): void {
RewriteHandler::register_rules();
$handler = new RewriteHandler();
$handler->add_rewrite_rules();
flush_rewrite_rules();
}

Expand Down
11 changes: 0 additions & 11 deletions src/Router/RewriteHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,15 +391,4 @@ private function get_current_canonical_url(): ?string {
return null;
}

/**
* Register rewrite rules statically.
*
* Used by activation hook to ensure rules are registered before flush.
*
* @return void
*/
public static function register_rules(): void {
$handler = new self();
$handler->add_rewrite_rules();
}
}