refactor: simplify ContentRenderer for clarity and DRY#11
Open
refactor: simplify ContentRenderer for clarity and DRY#11
Conversation
- Consolidate entity decoding logic (use decode_entities() in escape_yaml()) - Combine string replacements in escape_yaml() for efficiency - Extract taxonomy term formatting to helper method (eliminates DRY violation) - Remove redundant variable initialization in strip_code_block_markup() - Remove obvious comments that restate what code does No functional changes — output remains identical. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Refactors ContentRenderer to reduce duplication and simplify the frontmatter/YAML escaping logic while keeping the markdown output behavior the same.
Changes:
- Extracted shared category/tag frontmatter rendering into
format_taxonomy_terms(). - Simplified
escape_yaml()by reusingdecode_entities()and consolidating escaping into a singlestr_replace()call. - Removed redundant inline comments and tightened
$langassignment logic instrip_code_block_markup().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Consolidation note: overlaps with #14 in ContentRenderer. Recommend deciding one primary renderer path (merge one, rebase the other), to avoid churn. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies ContentRenderer by eliminating duplication and reducing complexity:
decode_entities()inescape_yaml()instead of duplicating thehtml_entity_decode()callstr_replace()calls inescape_yaml()into a single call for efficiencyformat_taxonomy_terms()helper method eliminates DRY violation between category and tag rendering$lang = ''declaration instrip_code_block_markup()No functional changes — output remains identical.
🤖 Generated with Claude Code