Fix comment type check missing empty string in email formatting#177
Open
Fix comment type check missing empty string in email formatting#177
Conversation
WordPress stores regular comments with comment_type as either empty string or 'comment'. The strict === 'comment' check missed empty strings, causing regular comments to be formatted as pingbacks/trackbacks in notification emails. Now checks against known non-comment types instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Test on Playground |
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
textdomain_mismatch | The "Text Domain" header in the plugin file does not match the slug. Found "yoast-comment-hacks", expected "comment-hacks". |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
aristath
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment_typeas either''(empty string) or'comment'for regular comments=== 'comment'strict comparison inadd_author_line()andadd_content_line()missed the empty string casecomment_typewere formatted as pingbacks/trackbacks in notification emails (showing "Website:" instead of "Author:" and "Excerpt:" instead of "Comment:")pingback/trackback) instead, matching the approach used in the switch statements elsewhere in the same classTest plan
🤖 Generated with Claude Code