Skip to content

Conversation

@hotwebmatter
Copy link

@hotwebmatter hotwebmatter commented Jan 23, 2020

Summary

Clone the code examples and extract the zipped archives for easier version control.

Also, rename the chapter directories so they'll list in properly sorted order.

Finally, optimize PNG files to correct colors and suppress libpng warnings.

hotwebmatter and others added 4 commits January 23, 2020 16:36
COMI-1240/unzip-everything
COMI-1240/unzip-everything
@hotwebmatter
Copy link
Author

@ProfessorBurke I think I'm done optimizing the PNG assets.

I fixed the sRGB color profile in all directories by executing this shell one-liner:

find . -name "*.png" -type f -print0 | xargs -0 mogrify 2>&1

I also corrected colors and alpha transparency as needed for some of the images in Chapter 1. I just have one question left about those images:

I am using star.png for the red star in my code because red_star.png is smaller than the others. Is that intentional, or should I also cp star.png red_star.png to make it larger?

And I guess one other question: Do you want me to zip everything back up in this branch before you merge it back in? (It's much easier for you to approve the code review if you can see the differences, although in this case the changes are mostly in binary files.)

@hotwebmatter
Copy link
Author

All the colorful stars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant