Add fex-20251205(most likely it doesn't work), fex-20251128 #1
Conversation
WalkthroughAdds new Fex entries to Box64 manifest and expands the simulator component list; updates aggregate counts in components index. Changes are data additions to manifests and API payloads only; no control-flow or public API signature changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
components/box64_manifest(1 hunks)components/index(1 hunks)simulator/v2/getComponentList(1 hunks)
🔇 Additional comments (1)
components/index (1)
1-58: Index totals and category counts are internally consistent
total_components(267) matches the sum of all categorycountvalues, and the Box64 categorycount: 15matches the 15 entries defined incomponents/box64_manifest. No issues here; once you fix the staletotalfield incomponents/box64_manifest, all three JSONs will be aligned.
| "id": 327, | ||
| "version": "1.0.0", | ||
| "version_code": 1, | ||
| "type": 1, | ||
| "name": "Box64-0.37-b2", | ||
| "logo": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/45e60d211d35955bd045aabfded4e64b.png", | ||
| "blurb": "", | ||
| "file_md5": "bfb6b3914b8f7abb792d8acafa676861", | ||
| "file_size": "4272182", | ||
| "download_url": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/bfb6b3914b8f7abb792d8acafa676861.tzst", | ||
| "file_name": "Box64-0.37-b2.tzst", | ||
| "display_name": "Box64-0.37-b2", | ||
| "gpu_range": "" | ||
| }, |
There was a problem hiding this comment.
Correct Box64-0.37-b2 URL and list total
Two data issues here:
-
Broken/inconsistent URL for Box64-0.37-b2 (id 327)
In this file thedownload_urluses the md5 as the filename, while both the manifest andfile_namehere useBox64-0.37-b2.tzst. This is almost certainly a bad URL and will make this component non-downloadable via the simulator payload.- "download_url": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/bfb6b3914b8f7abb792d8acafa676861.tzst", + "download_url": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/Box64-0.37-b2.tzst",
-
totaldoes not matchlistlength
There are 14 entries under"list", but"total"is13. To keep the sample payload coherent (and aligned with the Box64 category count / manifest), bump the total:- "total": 13, + "total": 14,
All other entries, including the new Fex-20251205 and Fex-20251025 items, look consistent with components/box64_manifest.
Also applies to: 67-80, 82-215, 217-219
🤖 Prompt for AI Agents
In simulator/v2/getComponentList around lines 37-50 (and similarly at 67-80,
82-215, 217-219), the Box64-0.37-b2 entry (id 327) has an incorrect download_url
that uses the MD5 as the filename while file_name and the manifest use
"Box64-0.37-b2.tzst"; replace the download_url value to point to the correct
filename (use the file_name value) so the URL matches the manifest and is
downloadable, and update the top-level "total" value from 13 to 14 to match the
actual number of items in the "list"; apply the same filename/URL consistency
check to the other ranges mentioned and fix any entries where download_url
incorrectly uses the md5 instead of the file_name.
hardWorker254
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
simulator/v2/getComponentList (1)
44-47: Box64-0.37-b2 download URL still uses MD5 hash instead of filename.The
download_urluses the MD5 hash as the filename whilefile_namespecifiesBox64-0.37-b2.tzst. This URL/filename mismatch will likely cause download failures.- "download_url": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/bfb6b3914b8f7abb792d8acafa676861.tzst", + "download_url": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/Box64-0.37-b2.tzst",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
components/box64_manifest(1 hunks)components/index(1 hunks)simulator/v2/getComponentList(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- components/index
- components/box64_manifest
🔇 Additional comments (3)
simulator/v2/getComponentList (3)
96-110: LGTM!The Fex-20251128 entry is well-formed with consistent
download_urlandfile_namevalues.
111-230: Existing Fex entries look consistent.All
download_urlvalues correctly match their correspondingfile_namevalues. The naming convention varies between hyphen (Fex-YYYYMMDD) and underscore (Fex_YYYYMMDD) formats across entries, but this appears to be an existing pattern in the data.
232-235: Total count is now correct; minor pageSize inconsistency.The
"total": 15correctly matches the 15 entries in the list. Note thatpageSizeis set to 10 while returning all 15 items — this is fine for a static mock response but would be inconsistent in a real paginated API.
| { | ||
| "id": 349, | ||
| "version": "1.0.0", | ||
| "version_code": 1, | ||
| "type": 1, | ||
| "name": "Fex-20251205", | ||
| "logo": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/45e60d211d35955bd045aabfded4e64b.png", | ||
| "blurb": "", | ||
| "file_md5": "67778a1a35c83ae3d3621c549bb3a008", | ||
| "file_size": "4251479", | ||
| "download_url": "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/fex-20251205.tzst", | ||
| "file_name": "fex-20251205.tzst", | ||
| "display_name": "Fex-20251205", | ||
| "gpu_range": "" | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the download URL is accessible
echo "Checking fex-20251205.tzst availability..."
curl -sI "https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/fex-20251205.tzst" 2>&1 | head -20
echo ""
echo "File size comparison (from manifest):"
echo "fex-20251205: 4251479 bytes (~4.05 MB)"
echo "fex-20251128: 15248636 bytes (~14.5 MB)"
echo "fex-20251025: 11580115 bytes (~11 MB)"Repository: Producdevity/gamehub-lite-api
Length of output: 966
Remove or fix the fex-20251205 entry — download URL returns HTTP 404.
The download URL (https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/fex-20251205.tzst) is not accessible and returns a 404 error. Either the release asset does not exist or the URL is incorrect. This entry cannot be used in its current state.
🤖 Prompt for AI Agents
In simulator/v2/getComponentList around lines 81 to 95 the Fex-20251205
component entry points to a download_url that returns HTTP 404; remove the whole
JSON object or replace it with a corrected entry whose download_url points to a
valid release asset (verify HTTP 200), and update file_name, file_md5 and
file_size to match the actual asset; after fixing, run a quick fetch/HEAD
request to confirm the URL is reachable and the checksum matches before
committing.
1 participant
This PR adds fex-20251205. I'm not sure it's a working translator, as the archive is half the size of fex-20251025. If you can, please test it. I've set the download URL to https://github.com/Producdevity/gamehub-lite-api/releases/download/Components/fex-20251205.tzst Also, please check my PR for errors. I'm not sure I did everything correctly.
Download link for fex-20251205:
https://drive.google.com/file/d/1QQ_-szwqkFy8OOl-yeBk8rK37xJYIewc/view?usp=sharing
Download link for fex-20251128(extracted from gamehub):
https://drive.google.com/file/d/1c7Zczg__eN3lg17dqWwWj_ERu07ptkec/view?usp=sharing
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.