Skip to content

Conversation

@rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Nov 27, 2025

Issue & Reproduction Steps

Expected behavior:
The Submit information and switch control should be according to figma design
Label
Actual behavior:
Warning is displayed down of the variables

Solution

  • adjust design
image

How to Test

please see the related ticket

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Note

Restyles the VariablesToSubmit panel with a card layout and external warning alert, and adds required-field detection within nested screens.

  • UI/UX (variables-to-submit.vue):
    • Redesigned layout with a bordered card, refined header, and toggle styling.
    • Moved the required-fields warning alert outside the card with new styling.
    • Added dedicated controls section (Select All, Search), improved search input, and dividers.
    • Polished variables list (spacing, scrollbar styling, hover states) and "no results" view.
  • Validation Logic:
    • Extended required-field discovery to traverse FormNestedScreen contents via getNestedScreenPages, ensuring required nested fields are flagged in missingRequiredVariables.

Written by Cursor Bugbot for commit 9ddaf2f. This will update automatically on new commits. Configure here.

@rodriquelca rodriquelca changed the base branch from develop to feature/FOUR-27781 November 27, 2025 19:53
@rodriquelca rodriquelca requested a review from caleeli November 27, 2025 19:54
@cypress
Copy link

cypress bot commented Nov 27, 2025

screen-builder    Run #2119

Run Properties:  status check passed Passed #2119  •  git commit 9ddaf2fb02: FOUR-28125: Submit information (enable/disable) does not have the same figma des...
Project screen-builder
Branch Review bugfix/FOUR-28125
Run status status check passed Passed #2119
Run duration 09m 50s
Commit git commit 9ddaf2fb02: FOUR-28125: Submit information (enable/disable) does not have the same figma des...
Committer Rodrigo Quelca
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 389
View all changes introduced in this branch ↗︎

@rodriquelca rodriquelca changed the title Bugfix/four 28125 FOUR-28125: Submit information (enable/disable) does not have the same figma design Nov 27, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 21

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@caleeli caleeli merged commit b517aed into feature/FOUR-27781 Nov 28, 2025
23 of 30 checks passed
@caleeli caleeli deleted the bugfix/FOUR-28125 branch November 28, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants