test : add unit tests for metricsCacheKey param serialization edge cases#849
test : add unit tests for metricsCacheKey param serialization edge cases#849tmdeveloper007 wants to merge 2 commits into
Conversation
|
@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
1aa538f to
4cfd47c
Compare
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Import pattern is correct — function imported from source. Three infrastructure issues to fix before merge:
- Missing
"test": "vitest run"inpackage.jsonscripts — tests can't run in CI without this. vitest.config.tsmissingresolve.alias—@/lib/*path aliases fail without:
import path from 'path'
export default defineConfig({
resolve: { alias: { '@': path.resolve(__dirname, 'src') } },
test: { globals: true }
})- Missing EOF newline on test file.
ee7ae2b to
51aacdd
Compare
|
This pull request is fully up-to-date with the latest upstream merges, all review items are addressed, local tests are passing cleanly, and it is fully ready to be merged! 🚀 |
Closes #826.
Summary of What Has Been Done:
Added edge case tests for metricsCacheKey param serialization to the existing metrics-cache.test.ts.
Changes Made:
Modified: test/metrics-cache.test.ts
Added tests:
Impact it Made:
Validates edge case param serialization. Catches any future regression in null/undefined filtering.