Skip to content

fix: prevent hydration mismatch in useHeatmapTheme by suppressing mismatch on theme element#841

Open
tmdeveloper007 wants to merge 3 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#817
Open

fix: prevent hydration mismatch in useHeatmapTheme by suppressing mismatch on theme element#841
tmdeveloper007 wants to merge 3 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#817

Conversation

@tmdeveloper007
Copy link
Copy Markdown
Contributor

fix: prevent hydration mismatch in useHeatmapTheme by suppressing mismatch on theme element

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:testing GSSoC type bonus: tests (+10 pts) labels May 23, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@tmdeveloper007 tmdeveloper007 force-pushed the #817 branch 4 times, most recently from 405de24 to 968fe2b Compare May 23, 2026 06:39
Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOF newline on e2e/landing.spec.js. Also: the returned suppressHydrationMismatch flag is not used by any call site — either apply suppressHydrationWarning in the component that consumes this hook, or remove the flag from the return value.

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

One issue to fix:

Missing EOF newline in e2e/landing.spec.js
The diff shows -});\n+});\ No newline at end of file — your change removes the trailing newline from the file. All files must end with a newline. Please restore it.

The hydration mismatch fix itself (mounted state, returning "default" until mounted) is correct and the approach is good.

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:intermediate GSSoC: Intermediate difficulty (35 pts) labels May 23, 2026
@tmdeveloper007 tmdeveloper007 force-pushed the #817 branch 3 times, most recently from 8b355fe to 0d6c58c Compare May 23, 2026 14:53
@tmdeveloper007
Copy link
Copy Markdown
Contributor Author

This pull request is fully up-to-date with the latest upstream merges, all review items are addressed, local tests are passing cleanly, and it is fully ready to be merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:intermediate GSSoC: Intermediate difficulty (35 pts) type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants