fix : replace SELECT * with explicit columns in data-export#834
fix : replace SELECT * with explicit columns in data-export#834tmdeveloper007 wants to merge 1 commit into
Conversation
|
@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Security issue: The explicit column list for user_github_accounts includes access_token:
.select("id, user_id, github_id, github_login, access_token, created_at")
This exports the plaintext OAuth token in the user data export. Remove access_token from the select list. Only include non-sensitive fields.
|
Security issue blocks this merge:
This was the vulnerability this PR (and our earlier fix in commit 435d85f) was meant to address. The current main branch already has this corrected to: .select("id, user_id, github_id, github_login, created_at")Please remove Also please rebase on main first — the current |
0b6eb0f to
ffc6955
Compare
|
Deployment failed with the following error: |
422023c to
712ab38
Compare
|
This pull request is fully up-to-date with the latest upstream merges, all review items are addressed, local tests are passing cleanly, and it is fully ready to be merged! 🚀 |
fix : replace SELECT * with explicit columns in data-export