test : added unit tests for scorePrMergeRate function#652
test : added unit tests for scorePrMergeRate function#652tmdeveloper007 wants to merge 1 commit into
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Two issues with this PR:
-
Missing EOF newline — test file must end with
\n -
Tests don't import actual source code — some tests copy-paste the implementation inside the test file (e.g., #662 redefines
getRateLimitRemainingFromResponselocally). Tests must import and test the real function fromsrc/. Reimplementing the function in the test only verifies the copy, not the actual code. -
No test runner configured — the project has no
jest,vitest, ortestscript inpackage.json. Please add vitest (or jest) config and atestscript so these tests can actually run in CI. Reference: project uses TypeScript sovitestwith@vitest/uiis the simplest fit.
Please fix all three and push again.
Closes #628.
Summary of What Has Been Done:
Added unit tests for scorePrMergeRate function.
Changes Made:
Impact it Made: