feat: add loading skeleton for PersonalRecords#578
Conversation
|
Someone is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Two issues to fix:
-
Broken indentation — the skeleton JSX block is unindented (starts at column 0 instead of matching surrounding code). Please fix indentation to match the rest of the component.
-
Skeleton layout mismatch — the loaded content shows 5 cards in a
grid-cols-5layout but the new skeleton shows only 3 rows in aspace-y-3list. The skeleton should mirror the actual loaded layout to prevent layout shift. Please restore the 5-card grid skeleton (matching the 5 personal records displayed).
Also add EOF newline if missing.
|
Thanks for the review @Priyanshu-byte-coder! I fixed the indentation issues, restored the skeleton to match the 5-card loaded layout to prevent layout shifts, and added the requested formatting adjustments. Kindly re-review it. Thank you! |
f55cc13
into
Priyanshu-byte-coder:main
|
🎉 Merged! Thanks for contributing to DevTrack. If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers. Keep an eye on open issues for your next contribution! |
Summary
Added loading skeleton states for
PersonalRecordsso users receive visual feedback while data is being fetched, matching the loading experience used in other dashboard widgets and reducing layout shifts.Closes #206
Type of Change
Changes Made
PersonalRecordsHow to Test
Steps for the reviewer to verify this works:
npm run devPersonalRecordsScreenshots (if UI change)
N/A
Checklist
npm run lintpasses locallynpm run type-check)