Skip to content

ci: remove authup version #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brucetony merged 1 commit into from
Mar 4, 2026
Merged

ci: remove authup version #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system-tests/environment/hub/hub-docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ services:
hub:

authup:
image: authup/authup:next
image: authup/authup
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify the changed compose line
echo "=== Checking hub-docker-compose.yml lines 58-66 ==="
fd hub-docker-compose.yml --exec sed -n '58,66p' {}

echo ""
echo "=== Searching for authup/authup references in the repository ==="
rg -n -C2 'authup/authup(:|@|$)' 2>/dev/null || echo "No matches found or pattern error"

echo ""
echo "=== File structure check ==="
fd hub-docker-compose.yml --exec wc -l {}

Repository: PrivateAIM/node-message-broker

Length of output: 771

🌐 Web query:

authup Docker Hub image latest tag digest registry

💡 Result:

  • Registry / image name (Docker Hub): docker.io/authup/authup (hub.docker.com)
  • Latest tag: latest (last pushed “6 days” ago on Docker Hub at time of lookup) (hub.docker.com)
  • Digests for authup/authup:latest (per platform shown on Docker Hub):
    • linux/amd64: sha256:db1f4f9d6aeb49674705f7a18573a94e9c5acddf084f74653c2194feda224a56 (hub.docker.com)
    • linux/arm64: sha256:cac3286458351aa483bca59bdf33e2372d021afb9534aab4b9fb32e8b41f68f0 (hub.docker.com)

To pin by digest, use the @sha256:... form (e.g., authup/authup@sha256:...). (docs.docker.com)

Citations:

Use an immutable Authup image reference for deterministic CI.

Line 62 uses an unqualified image reference (authup/authup) which resolves to the floating latest tag, causing non-deterministic system-test behavior across runs. Pin to a digest or inject a pinned value via CI environment variable.

Suggested change 
-    image: authup/authup
+    image: ${AUTHUP_IMAGE:-authup/authup@sha256:db1f4f9d6aeb49674705f7a18573a94e9c5acddf084f74653c2194feda224a56}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
image: authup/authup
image: ${AUTHUP_IMAGE:-authup/authup@sha256:db1f4f9d6aeb49674705f7a18573a94e9c5acddf084f74653c2194feda224a56}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@system-tests/environment/hub/hub-docker-compose.yml` at line 62, Replace the
floating image reference "image: authup/authup" with a deterministic, pinned
image reference: either hard-pin to a specific digest (e.g.,
authup/authup@sha256:...) or make it configurable via an environment variable
(e.g., use AUTHUP_IMAGE and fall back to a pinned default) so CI runs use an
immutable Authup image; update the docker-compose service definition that
currently contains "image: authup/authup" to use the chosen pinned or
env-substituted value.

restart: always
depends_on:
mysql:
Expand Down
Loading