Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| if not pyproject_file.is_file(): | ||
| logger.debug(f"pyproject.toml not found in installed package {module_name}") | ||
| logger.debug(f"pyproject.toml not found for installed module {module_name}") |
There was a problem hiding this comment.
Skill docs missing for workflow change
Low Severity
This PR changes evaluation workflow behavior in verifiers/scripts/eval.py by altering how get_env_eval_defaults resolves pyproject.toml for environments, but no corresponding skills/*/SKILL.md updates are included. That violates the Skills Updates rule for user-facing workflow changes in verifiers/scripts/*.py.
Triggered by project rule: BugBot Instructions
…e-envs-as-packages # Conflicts: # verifiers/envs/experimental/cli_agent_env.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Medium Risk
Changes how eval run defaults are discovered from environment modules, which can alter
num_examples/rollouts_per_exampleselection at runtime. The logic is small and covered by new tests, but impacts core CLI configuration behavior.Overview
Eval CLI now loads per-environment eval defaults by locating the environment module on disk via
importlib.util.find_spec, so defaults can be read frompyproject.tomlfor both package-based envs and single-file env modules (instead of only installed packages).Adds targeted tests covering defaults resolution for package and single-file modules. Separately hardens
CliAgentEnvinterception handling by making_interception_serverexplicitly optional and routing access through_require_interception_server(), reducing the chance ofNonedereferences during rollout setup/teardown.Written by Cursor Bugbot for commit 4bfde49. This will update automatically on new commits. Configure here.