-
Notifications
You must be signed in to change notification settings - Fork 0
CPU topology v2 phase 6: migrate profiles and core masks to CpuSelection #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PrimeBuild-pc
merged 3 commits into
main
from
codex/cpu-topology-v2-phase-6-profile-cpuselection-migration
May 20, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * ThreadPilot - Advanced Windows Process and Power Plan Manager | ||
| * Copyright (C) 2025 Prime Build | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as published by | ||
| * the Free Software Foundation, version 3 only. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
| namespace ThreadPilot.Models | ||
| { | ||
| public static class CpuAffinityProfileSchemaVersions | ||
| { | ||
| public const int Legacy = 1; | ||
|
|
||
| public const int CpuSelection = 2; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * ThreadPilot - Advanced Windows Process and Power Plan Manager | ||
| * Copyright (C) 2025 Prime Build | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as published by | ||
| * the Free Software Foundation, version 3 only. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
| namespace ThreadPilot.Models | ||
| { | ||
| public sealed record CpuSelectionMigrationMetadata | ||
| { | ||
| public bool CreatedFromLegacyAffinityMask { get; init; } | ||
|
|
||
| public bool CreatedFromLegacyCoreMask { get; init; } | ||
|
|
||
| public bool ReviewRequired { get; init; } | ||
|
|
||
| public string MigrationConfidence { get; init; } = string.Empty; | ||
|
|
||
| public string Reason { get; init; } = string.Empty; | ||
|
|
||
| public CpuTopologySignature? TopologySignature { get; init; } | ||
|
|
||
| public long? SourceLegacyAffinityMask { get; init; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * ThreadPilot - Advanced Windows Process and Power Plan Manager | ||
| * Copyright (C) 2025 Prime Build | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as published by | ||
| * the Free Software Foundation, version 3 only. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
| namespace ThreadPilot.Models | ||
| { | ||
| using System.Diagnostics; | ||
|
|
||
| public sealed class ProcessProfileSnapshot | ||
| { | ||
| public int ProfileSchemaVersion { get; set; } = CpuAffinityProfileSchemaVersions.Legacy; | ||
|
|
||
| public string ProcessName { get; set; } = string.Empty; | ||
|
|
||
| public ProcessPriorityClass Priority { get; set; } | ||
|
|
||
| public long ProcessorAffinity { get; set; } | ||
|
|
||
| public CpuSelection? CpuSelection { get; set; } | ||
|
|
||
| public CpuSelectionMigrationMetadata? CpuSelectionMigration { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * ThreadPilot - Advanced Windows Process and Power Plan Manager | ||
| * Copyright (C) 2025 Prime Build | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as published by | ||
| * the Free Software Foundation, version 3 only. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
| namespace ThreadPilot.Services | ||
| { | ||
| using ThreadPilot.Models; | ||
|
|
||
| public sealed record CpuSelectionMigrationResult( | ||
| CpuSelection Selection, | ||
| CpuSelectionMigrationMetadata Metadata); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guard skips migration whenever
CpuSelectionis already set, so later edits toBoolMask(saved viaUpdateMaskAsync->SaveMasksAsync) do not refresh the persistedCpuSelection. After any mask edit, the file can contain aboolMaskandcpuSelectionthat describe different CPU sets, which will produce incorrect behavior once CpuSelection-based mask application is used.Useful? React with 👍 / 👎.