Rename and isolate injected state variables #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two class variables are injected outside of the `__init__()` of the class. This is done, mostly, to avoid the complexity of matching the parent class init just to declare these. Name mangling these two will prevent any possibility of collision with the parent class and feel like best practice here. Renaming them to be more accurate to what they are.
Preocts
force-pushed
the
isolate-class-state
branch
from
9f1ec4b to
02a3527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two class variables are injected outside of the
__init__()of the class. This is done, mostly, to avoid the complexity of matching the parent class init just to declare these.Name mangling these two will prevent any possibility of collision with the parent class and feel like best practice here.
Renaming them to be more accurate to what they are.