fix(quality): resolve final 4 CodeQL alerts by Prekzursil · Pull Request #129 · Prekzursil/SWFOC-Mod-Menu

Prekzursil · 2026-04-04T07:05:05Z

Summary

Fix 4 remaining CodeQL alerts found after main-branch re-scan
cs/useless-upcast (2): Replace (object) cast with explicit new object[] array construction
cs/dereferenced-value-may-be-null (1): Remove redundant ! null-forgiving operator
cs/linq/missed-select (1): Flatten nested foreach with SelectMany

Test plan

Build passes (0 warnings, 0 errors)
CodeQL scan shows 0 open alerts after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Enhanced Steam workshop content discovery to properly scan all configured library locations.
Tests
- Refined test assertions and updated reflection-based test invocations for improved test reliability.

- cs/useless-upcast: replace (object) cast with explicit new object[] to prevent params array flattening without triggering upcast warning - cs/dereferenced-value-may-be-null: remove redundant ! null-forgiving operator (FluentAssertions handles null assertion) - cs/linq/missed-select: flatten nested foreach with SelectMany to eliminate intermediate variable mapping Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

devloai · 2026-04-04T07:05:10Z

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

qodo-code-review · 2026-04-04T07:05:21Z

Review Summary by Qodo

Resolve final 4 CodeQL alerts with code quality improvements

🐞 Bug fix

Walkthroughs

Description

• Flatten nested foreach with SelectMany to eliminate intermediate variable
• Replace (object) cast with explicit new object[] array construction
• Remove redundant null-forgiving operator in assertion chain

Diagram

flowchart LR
  A["CodeQL Alerts"] --> B["Nested Loop Flattening"]
  A --> C["Useless Upcast Fix"]
  A --> D["Null-Forgiving Operator Removal"]
  B --> E["SelectMany Refactor"]
  C --> F["Explicit Array Construction"]
  D --> G["Cleaner Assertions"]

File Changes

1. src/SwfocTrainer.Runtime/Services/ModDependencyValidator.cs 🐞 Bug fix +14/-17

Flatten nested foreach with SelectMany

• Replaced nested foreach loops with SelectMany to flatten drive discovery logic
• Eliminated intermediate steamCandidates array variable
• Improved code readability by reducing nesting depth
• Maintains same functionality while resolving cs/linq/missed-select alert

src/SwfocTrainer.Runtime/Services/ModDependencyValidator.cs

2. tests/SwfocTrainer.Tests/App/ProgramServiceRegistrationTests.cs 🐞 Bug fix +1/-1

Remove redundant null-forgiving operator
• Removed redundant null-forgiving operator (!) from remoteManifestUrl!
• FluentAssertions NotBeNull() already handles null assertion
• Simplifies code without changing behavior
tests/SwfocTrainer.Tests/App/ProgramServiceRegistrationTests.cs

3. tests/SwfocTrainer.Tests/Profiles/ModOnboardingCalibrationCoverageSweepTests.cs 🐞 Bug fix +2/-2

Replace object cast with explicit array construction
• Replaced (object) cast with explicit new object[] { samples } array construction
• Prevents params array flattening without triggering upcast warning
• Applied to both InferWorkshopIds and InferPathHints method calls
• Resolves cs/useless-upcast CodeQL alerts
tests/SwfocTrainer.Tests/Profiles/ModOnboardingCalibrationCoverageSweepTests.cs

coderabbitai · 2026-04-04T07:05:23Z

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 66619296-379d-4787-9686-54a2f88865a6

📥 Commits

Reviewing files that changed from the base of the PR and between 74dd4d1 and 74175a3.

📒 Files selected for processing (3)

src/SwfocTrainer.Runtime/Services/ModDependencyValidator.cs
tests/SwfocTrainer.Tests/App/ProgramServiceRegistrationTests.cs
tests/SwfocTrainer.Tests/Profiles/ModOnboardingCalibrationCoverageSweepTests.cs

📝 Walkthrough

Walkthrough

Refactoring of the workshop root discovery mechanism that restructures enumeration logic using SelectMany and reorganizes library folder parsing, alongside test updates for assertion syntax and reflection-based method invocation parameters.

Changes

Cohort / File(s)	Summary
Workshop Discovery Implementation `src/SwfocTrainer.Runtime/Services/ModDependencyValidator.cs`	Refactored `DiscoverWorkshopRoots()` to use `SelectMany` for flattening candidate Steam root paths and restructured the loop logic. Moved `libraryfolders.vdf` parsing outside conditional logic, applying it per-candidate Steam root iteration.
Test Assertion & Reflection Updates `tests/SwfocTrainer.Tests/App/ProgramServiceRegistrationTests.cs`, `tests/SwfocTrainer.Tests/Profiles/ModOnboardingCalibrationCoverageSweepTests.cs`	Removed null-forgiving operator from test assertion; updated reflection-based method invocations to pass `samples` via `new object[] { samples }` instead of `(object)` cast.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hops through code with glee,
Steam roots now enumerate free,
SelectMany flattens the way,
Tests assert without delay,
Workshop discovery—hopping spree! 🌳✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete against the template; it lacks required sections including Risk assessment, Affected Profiles, Reliability Evidence, Rollback steps, and Scope Guard checkboxes.	Complete the description by adding Risk level, Affected Profiles checkboxes, Reliability Evidence section with test results, Rollback procedure, and Scope Guard checklist items to meet repository requirements.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title concisely and accurately describes the main objective: resolving CodeQL alerts through code quality improvements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/codeql-final-4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

qodo-code-review · 2026-04-04T07:05:23Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

deepsource-io · 2026-04-04T07:05:39Z

DeepSource Code Review

We reviewed changes in 74dd4d1...74175a3 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Updated (UTC)	Details
Terraform	Apr 4, 2026 7:05a.m.	Review ↗
SQL	Apr 4, 2026 7:05a.m.	Review ↗
Rust	Apr 4, 2026 7:05a.m.	Review ↗
Shell	Apr 4, 2026 7:05a.m.	Review ↗
Ruby	Apr 4, 2026 7:05a.m.	Review ↗
PHP	Apr 4, 2026 7:05a.m.	Review ↗
Kotlin	Apr 4, 2026 7:05a.m.	Review ↗
Swift	Apr 4, 2026 7:05a.m.	Review ↗
Scala	Apr 4, 2026 7:05a.m.	Review ↗
Python	Apr 4, 2026 7:05a.m.	Review ↗
JavaScript	Apr 4, 2026 7:05a.m.	Review ↗
Java	Apr 4, 2026 7:05a.m.	Review ↗
Go	Apr 4, 2026 7:05a.m.	Review ↗
Docker	Apr 4, 2026 7:05a.m.	Review ↗
C & C++	Apr 4, 2026 7:05a.m.	Review ↗
Ansible	Apr 4, 2026 7:05a.m.	Review ↗

sonarqubecloud · 2026-04-04T07:06:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codacy-production · 2026-04-04T07:07:20Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity ✅ 0 (≤ 10 complexity)

Duplication ✅ 0 (≤ 0 duplication)

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

Prekzursil merged commit 7330431 into main Apr 4, 2026
44 of 53 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(quality): resolve final 4 CodeQL alerts#129

fix(quality): resolve final 4 CodeQL alerts#129
Prekzursil merged 1 commit into
mainfrom
fix/codeql-final-4

Prekzursil commented Apr 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

devloai Bot commented Apr 4, 2026

Uh oh!

qodo-code-review Bot commented Apr 4, 2026

Uh oh!

coderabbitai Bot commented Apr 4, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (2 warnings)

Uh oh!

qodo-code-review Bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Apr 4, 2026

Uh oh!

codacy-production Bot commented Apr 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Prekzursil commented Apr 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

devloai Bot commented Apr 4, 2026

Uh oh!

qodo-code-review Bot commented Apr 4, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

coderabbitai Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (2 warnings)

Uh oh!

qodo-code-review Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Great, no issues found!

Uh oh!

deepsource-io Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

sonarqubecloud Bot commented Apr 4, 2026

Quality Gate passed

Uh oh!

codacy-production Bot commented Apr 4, 2026

Up to standards ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Prekzursil commented Apr 4, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 4, 2026 •

edited

Loading

qodo-code-review Bot commented Apr 4, 2026 •

edited

Loading

deepsource-io Bot commented Apr 4, 2026 •

edited

Loading