Skip to content

Conversation

@qtuantruong
Copy link
Member

Description

Fix typing issues in order to upgrade Numpy to newer versions.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@qtuantruong qtuantruong requested a review from hieuddo April 13, 2025 18:59
@hieuddo
Copy link
Member

hieuddo commented Apr 14, 2025

@tqtg will the failed buildings be fixed after your other PR #665?

By the way, can we also resolve the issue with the incompatible gcc version mentioned in #655?

@qtuantruong
Copy link
Member Author

@hieuddo yes, #665 is to address the failed buildings. For the gcc issue, we need to see if changing the env of build workflow to match gcc version of GG colab is the right thing to do. Anw, it should be a separate PR rather than this one

@qtuantruong qtuantruong merged commit d20b93e into PreferredAI:master Apr 14, 2025
9 of 14 checks passed
@qtuantruong qtuantruong deleted the upgrade-numpy2 branch April 14, 2025 21:19
qtuantruong added a commit to qtuantruong/cornac that referenced this pull request Oct 25, 2025
qtuantruong added a commit to qtuantruong/cornac that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants