QR codes for interactive programs#2676
Open
ascholerChemeketa wants to merge 7 commits intoPreTeXtBook:masterfrom
Open
QR codes for interactive programs#2676ascholerChemeketa wants to merge 7 commits intoPreTeXtBook:masterfrom
ascholerChemeketa wants to merge 7 commits intoPreTeXtBook:masterfrom
Conversation
Contributor
Author
|
BTW - I hate that the url needs to go in a p and thus gets indented. Not sure how to avoid that though. |
Contributor
Author
|
Draft while working on: |
6e07cf3 to
478723b
Compare
Contributor
Author
|
Updated based on results of Content since last review:
I kept the I believe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds QR code generation for interactive programs (activecode/codelens).
Because programs already may have width issues in print, I don't want to do the link side by side with the program itself. So instead, an assemblage with a link/qr is added after the program. I think it is good to have that block visually separated as a "here is something not part of the core text". But I feel no real ownership of that layout.
I figure you will want to do your own test of generation, so no commit with the updated QR codes.
First commit fixes a breaking bug if version 8+ of qrcode is installed:
https://pypi.org/project/qrcode/
If the rest of this ends up languishing, it might be worth breaking that commit out.