Fix PowerShell 5.1 compatibility in New-HelpCabinetFile#843
Open
kborowinski wants to merge 1 commit intoPowerShell:mainfrom
Open
Fix PowerShell 5.1 compatibility in New-HelpCabinetFile#843kborowinski wants to merge 1 commit intoPowerShell:mainfrom
kborowinski wants to merge 1 commit intoPowerShell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #842
New-HelpCabinetFileso it can run on Windows PowerShell 5.1 by avoiding unconditional use of the$IsWindowsautomatic variable$IsWindowsis available in PowerShell Core, but it is not defined in Windows PowerShell 5.1. The updated check only evaluates$IsWindowswhen$PSEditionisCore, while preserving the existing behavior that blocks this cmdlet on non-Windows platforms.PR Context
New-HelpCabinetFileis a Windows-only cmdlet, but the previous platform check could fail on Windows PowerShell 5.1 because$IsWindowsdoes not exist there.This change allows the cmdlet to continue working on Windows PowerShell 5.1 while still throwing the existing unsupported-platform error when running PowerShell Core on non-Windows systems.
This change is