Fix registry resource manifest copy for packaging#1517
Open
SteveL-MSFT wants to merge 1 commit intoPowerShell:mainfrom
Open
Fix registry resource manifest copy for packaging#1517SteveL-MSFT wants to merge 1 commit intoPowerShell:mainfrom
SteveL-MSFT wants to merge 1 commit intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates packaging metadata so the Windows registry resource ships the correct manifest list file (registry.dsc.manifests.json) after the RegistryList/manifest changes, preventing packaging failures caused by referencing the old registry.dsc.resource.json filename.
Changes:
- Replace
registry.dsc.resource.jsonwithregistry.dsc.manifests.jsonin WindowsPackageFiles. - Update the registry project’s Windows
CopyFilesentry to copyregistry.dsc.manifests.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
After adding the RegistryList resource and changing the manifest file, didn't update the data for packaging so it fails trying to find the old file when it should be
registry.dsc.manifests.json