-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: show all frames #42964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: show all frames #42964
Conversation
Signed-off-by: Hugues Pouillot <hpouillot@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
frontend/src/lib/components/Errors/ExceptionList/RawExceptionList.tsx, line 36-42 (link)syntax:
renderFilteredTracesignature was changed to includeallFramesas the first parameter, butRawExceptionListwas not updated. This will cause a TypeScript error.
3 files reviewed, 2 comments
| if (exceptionCount == 1) { | ||
| onShowAllFrames() | ||
| } | ||
| }, [exceptionCount]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Missing onShowAllFrames in dependency array - React hooks lint warning. Consider adding it or using // eslint-disable-next-line react-hooks/exhaustive-deps if intentional.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/lib/components/Errors/StackTrace/FilteredStackTrace.tsx
Line: 20:20
Comment:
**style:** Missing `onShowAllFrames` in dependency array - React hooks lint warning. Consider adding it or using `// eslint-disable-next-line react-hooks/exhaustive-deps` if intentional.
How can I resolve this? If you propose a fix, please make it concise.|
Size Change: 0 B Total Size: 3.51 MB ℹ️ View Unchanged
|
Signed-off-by: Hugues Pouillot <hpouillot@gmail.com>
Visual regression: Storybook UI snapshots updatedChanges: 4 snapshots (4 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Visual regression: Storybook UI snapshots updatedChanges: 2 snapshots (2 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Problem
Changes