Skip to content

Conversation

@hpouillot
Copy link
Contributor

@hpouillot hpouillot commented Dec 8, 2025

Problem

  • When one exception has no in-app frames, show all frames is stuck to show all frames

Changes

  • Trigger automatically show all frames only when there is one exception
  • Display small banner otherwise
  • Fix code context line sorting
image

Signed-off-by: Hugues Pouillot <hpouillot@gmail.com>
@hpouillot hpouillot requested review from a team, ablaszkiewicz, daibhin and oliverb123 December 8, 2025 18:11
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. frontend/src/lib/components/Errors/ExceptionList/RawExceptionList.tsx, line 36-42 (link)

    syntax: renderFilteredTrace signature was changed to include allFrames as the first parameter, but RawExceptionList was not updated. This will cause a TypeScript error.

3 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

if (exceptionCount == 1) {
onShowAllFrames()
}
}, [exceptionCount])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing onShowAllFrames in dependency array - React hooks lint warning. Consider adding it or using // eslint-disable-next-line react-hooks/exhaustive-deps if intentional.

Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/lib/components/Errors/StackTrace/FilteredStackTrace.tsx
Line: 20:20

Comment:
**style:** Missing `onShowAllFrames` in dependency array - React hooks lint warning. Consider adding it or using `// eslint-disable-next-line react-hooks/exhaustive-deps` if intentional.

How can I resolve this? If you propose a fix, please make it concise.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Size Change: 0 B

Total Size: 3.51 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.51 MB

compressed-size-action

hpouillot and others added 2 commits December 8, 2025 19:17
Signed-off-by: Hugues Pouillot <hpouillot@gmail.com>
@posthog-bot
Copy link
Contributor

Visual regression: Storybook UI snapshots updated

Changes: 4 snapshots (4 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

@posthog-bot
Copy link
Contributor

Visual regression: Storybook UI snapshots updated

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants