fix: type warning on new_context#558
Merged
marandaneto merged 2 commits intoPostHog:mainfrom May 9, 2026
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix type warning on `new_context`" | Re-trigger Greptile |
new_contextnew_context
marandaneto
approved these changes
May 9, 2026
Member
|
@itsaphel can you add a changeset with sampo? |
Contributor
|
Reviews (2): Last reviewed commit: "changeset" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
When using a strict Python typechecker, Posthog's
new_contextfunction raises a type warning:This fixes that by assigning a type to
client💚 How did you test it?
Type fix only, ran typechecker
📝 Checklist
If releasing new changes
sampo addto generate a changeset file