Add mode configuration option#114
Conversation
|
@martosaur thanks for the PR but thats a breaking change and we cannot simply remove
we can fix this in this PR only and follow up with another PR for a different approach but lets not address both things here that also have a breaking change |
5d7b1cc to
e74c07f
Compare
|
Hi @marandaneto , nice to meet you! Thanks for taking a look.
That's a good call out! To be clar, the option is not removed, just merely deprecated. We still accept it and if passed, it will work as before. That should be backwards compatible change. I've pushed a test to better highlight this.
I'm confused, I don't see this callback anywhere? |
|
@martosaur https://posthog.com/docs/libraries/python#disabling-requests-during-tests SDKs should not throw if So I think this PR should not yet add another public API to address the very same issue. |
💡 Motivation and Context
Should address #81 (see comment)
Changes:
enable: falsein configuration but still tried to use default PostHog instance.mode :: :normal | :drop_events | :test.normalmode is, well, normal.testmode is basically currenttest_mode: true(and thustest_modeoption is deprecated).drop_eventssimply drops all events instead of sending them to PostHog.💚 How did you test it?
Unit tests
📝 Checklist
If releasing new changes
sampo addto generate a changeset file