Improve Sender batching logic#113
Open
martosaur wants to merge 2 commits intoPostHog:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Currently, Sender will occasionally attempt to send empty batches and get 400 from the ingestion API. This is happening due to a flaw in batching logic: whenever we receive first event in a batch, we set a timer. But if max batch size is reached, we send the batch immediately. This means that when the timer fires off, current batch can be empty. This PR contains 2 improvements:
💚 How did you test it?
Unit tests
📝 Checklist
If releasing new changes
sampo addto generate a changeset file