feat(workflows): add push subscription functionality#473
feat(workflows): add push subscription functionality#473havenbarnes wants to merge 22 commits intomainfrom
Conversation
posthog-android Compliance ReportDate: 2026-04-30 18:24:24 UTC
|
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ❌ | 293ms |
Failures
request_payload.request_with_person_properties_device_id
404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
…o add-push-notifications
|
@PostHog/team-client-libraries could I get a review on this? |
|
@havenbarnes @ioannisj and @turnipdabeets will take a look |
…o add-push-notifications
| import android.util.Base64 | ||
| import android.util.DisplayMetrics | ||
| import android.view.WindowManager | ||
| import androidx.core.net.toUri |
There was a problem hiding this comment.
lets rollback those unrelated changes
| import androidx.core.graphics.createBitmap | ||
| import androidx.core.view.ViewCompat | ||
| import androidx.core.view.WindowInsetsCompat | ||
| import androidx.core.view.isNotEmpty |
There was a problem hiding this comment.
lets rollback those unrelated changes
| implementation("androidx.lifecycle:lifecycle-process:${PosthogBuildConfig.Dependencies.LIFECYCLE}") | ||
| implementation("androidx.lifecycle:lifecycle-common-java8:${PosthogBuildConfig.Dependencies.LIFECYCLE}") | ||
| implementation("androidx.core:core:${PosthogBuildConfig.Dependencies.ANDROIDX_CORE}") | ||
| implementation("androidx.core:core-ktx:${PosthogBuildConfig.Dependencies.ANDROIDX_CORE}") |
There was a problem hiding this comment.
ktx brings more dependencies, do we actually need it?
| * @property apiKey the PostHog API Key | ||
| * @property distinctId the user's distinct ID | ||
| * @property deviceToken the device push token (FCM or APNS) | ||
| * @property platform the platform ("android" or "ios") | ||
| * @property appId the Firebase project_id (for Android) or APNS bundle_id (for iOS) | ||
| */ | ||
| internal data class PostHogPushSubscriptionRequest( | ||
| @SerializedName("api_key") | ||
| val apiKey: String, |
There was a problem hiding this comment.
apiKey is now called projectToken, since we can use SerializedName, lets use the "new name" from now on
4 participants
💡 Motivation and Context
This will need to be merged after the posthog PR stack PostHog/posthog#53276 and documentation updates: PostHog/posthog.com#16177
PostHog/posthog#44444
We're adding push notification channel to workflows, and SDKs need to send us their device tokens to fulfill the push subscription on our end
💚 How did you test it?
Tested everything end to end locally with a workflow, using FCM with emulator:
Added tests for new logic
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file