Add dynamic warm capacity target computation#605
Merged
Conversation
cbdbd39 to
5b7c8da
Compare
5b7c8da to
5b1be74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warm_capacity_demand_ttlto at leastwarm_capacity_miss_windowshared_warm_targetas the default image base target and keep pinned-image floors separateThis intentionally keeps the PR C/D boundary: PR C computes bucket-derived targets and preserves
max_workers=0as unbounded; PR D will wire these effective targets into the janitor reconciler, remove the #597 in-memory counter path, and add the public README/example/usage docs plus CLI flags for the dynamic knobs.Tests
go test ./configresolvego test .go test ./controlplanego test ./cmd/duckgres-controlplanego test -tags kubernetes -run 'TestOrgRouterAdapterSetWarmCapacityTargetZeroClearsAllWarmTargets|TestOrgRouterReconcileWarmCapacity|TestComputeDynamicWarmCapacityTargets' ./controlplanego test -run 'TestRecordWarmCapacityMiss|TestListWarmCapacityMissesSince|TestPruneWarmCapacityMissBuckets' ./tests/configstorego test -tags kubernetes ./controlplane ./cmd/duckgres-controlplanego test ./...was run; it failed in existingtests/integrationcatalog compatibility testTestCatalogPsqlCommands/psql_dnbecause Duckgres returned 3 schema rows vs PostgreSQL's 2.