feat: bundle PostHog ducklake fork (v1.0-posthog.1)#556
Merged
Conversation
Switches the ducklake extension shipped in the duckgres and duckgres-worker images from the upstream extensions.duckdb.org build to PostHog's fork at https://github.com/PostHog/ducklake/releases. Mirrors the existing httpfs override pattern. Also adds ducklake.duckdb_extension to shouldRefreshBundledExtension so the cached copy on a long-lived data-dir PVC is replaced when the image ships a newer fork build — same rationale as postgres_scanner. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Already covered by TestSeedBundledExtensionsReplacesExistingFilesWithUpdatedContents exercising the same code path via postgres_scanner. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
After bundling the v1.0-posthog.1 fork in Dockerfile.worker, add a kind- cluster integration test that queries duckdb_extensions().extension_version on a worker and asserts it matches the fork's commit short SHA (90dc1f24) rather than the upstream build's. The expected value lives next to the test with a comment pointing at DUCKLAKE_EXTENSION_TAG in the Dockerfiles so the two move together. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ducklake.duckdb_extensionin bothDockerfileandDockerfile.workerfrom the upstreamextensions.duckdb.orgbuild to PostHog's fork at https://github.com/PostHog/ducklake/releases/tag/v1.0-posthog.1. Mirrors the existing httpfs override pattern (benben/duckdb-httpfs fork). Tag is parameterised via--build-arg DUCKLAKE_EXTENSION_TAG=...for future bumps.ducklake.duckdb_extensiontoshouldRefreshBundledExtensionso the cached copy on a long-lived data-dir PVC is replaced when the image ships an updated fork build — same rationale aspostgres_scanner(the previous symptom was stale cached extensions silently outlasting image upgrades).The runtime path is unchanged:
bootstrapBundledExtensionsseeds<data-dir>/extensions/v1.5.2/linux_<arch>/, the DSN already setsallow_unsigned_extensions=true, andINSTALL ducklake; LOAD ducklake(server.go:1217) finds the pre-seeded binary without a network fetch.Test plan
go build ./...go test ./server -run 'BundledExtensions|SeedBundled'— addedTestSeedBundledExtensionsRefreshesDucklakecovering the new refresh-allowlist behaviour.ducklake-linux-{amd64,arm64}.duckdb_extensionassets (verified to exist on the release).LOAD ducklake;succeeds, andSELECT * FROM duckdb_extensions() WHERE extension_name='ducklake'shows the fork's extension binary loaded from the local cache.LOADwill fail with a version mismatch (same failure mode called out inDockerfile.worker:18-23).🤖 Generated with Claude Code