You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
apps/code/src/renderer/components/permissions/McpPermission.tsx, line 40 (link)
The posthogDisplay.input field is designed as "Args to show as the input preview" (per the JSDoc in posthog-exec-display.ts), but fullInput always uses formatInput(toolCall.rawInput) — which for a call execute-sql {"query":"select 1"} invocation shows the outer {"command":"call execute-sql {…}"} wrapper instead of the cleaner extracted {"query":"select 1"}. The PostHogExecDisplay.input value goes entirely unused.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/components/permissions/McpPermission.tsx
Line: 40
Comment:
The `posthogDisplay.input` field is designed as "Args to show as the input preview" (per the JSDoc in `posthog-exec-display.ts`), but `fullInput` always uses `formatInput(toolCall.rawInput)` — which for a `call execute-sql {"query":"select 1"}` invocation shows the outer `{"command":"call execute-sql {…}"}` wrapper instead of the cleaner extracted `{"query":"select 1"}`. The `PostHogExecDisplay.input` value goes entirely unused.
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---### Issue 1 of 1
apps/code/src/renderer/components/permissions/McpPermission.tsx:40
The `posthogDisplay.input` field is designed as "Args to show as the input preview" (per the JSDoc in `posthog-exec-display.ts`), but `fullInput` always uses `formatInput(toolCall.rawInput)` — which for a `call execute-sql {"query":"select 1"}` invocation shows the outer `{"command":"call execute-sql {…}"}` wrapper instead of the cleaner extracted `{"query":"select 1"}`. The `PostHogExecDisplay.input` value goes entirely unused.
```suggestion const fullInput = posthogDisplay?.input ?? formatInput(toolCall.rawInput);```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MCP permissions requests lack context - e.g. here i have no idea if i want to approve
execlolChanges
adds more context to the MCP permission requests
How did you test this?
manually / storybook
Publish to changelog?
no