Conversation
…ollow-ups after cloud run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three issues with cloud task follow-ups in the desktop app:
autoInitializeSession()can both callinitializeSession()concurrently, creating duplicate sessions and sending theinitial prompt twice (duplicate Slack messages).
agent response was not being relayed back to Slack.
readOnlyMessageand changedisRunningto be false when cloud run is terminal, blocking the editor aftertask completion.
Changes
initializationPromiselock to prevent concurrent session creation, withpendingEventsbuffer that replays SSE events after the session attaches.end_turnon follow-ups and resumes, callrelayAgentResponse()to postthe agent's reply to Slack. Return
assistant_messagein the prompt response forcallers that need it synchronously.
currentTurnMessagestracking inSessionLogWriterwithgetFullAgentResponse()andresetTurnMessages()for accurate per-turn messageextraction.
readOnlyMessagefromuseSessionViewState,SessionView,TaskLogsPanel, andCommandCenterSessionView. RestoreisRunning = trueforcloud tasks so the editor stays enabled after completion.