Skip to content

fix: Fix the message editor "disabled" attribute not actually disabling the input #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
charlesvien wants to merge 2 commits into
base: 01-13-pull_exponential_backoff_into_a_util
Choose a base branch
from
+15 −12
Draft

fix: Fix the message editor "disabled" attribute not actually disabling the input #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb80a7
Fix the message editor "disabled" attribute not actually disabling th…
charlesvien Jan 13, 2026
0aad2bc
lint
charlesvien Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/array/src/renderer/features/message-editor/components/MessageEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ export const MessageEditor = forwardRef<EditorHandle, MessageEditorProps>(
sessionId,
taskId,
placeholder,
disabled,
disabled: isDisabled,
isLoading,
isCloud,
autoFocus,
context: { taskId, repoPath },
Expand Down Expand Up @@ -138,7 +139,7 @@ export const MessageEditor = forwardRef<EditorHandle, MessageEditorProps>(
<Flex justify="between" align="center">
<Flex gap="2" align="center">
<EditorToolbar
disabled={disabled}
disabled={isDisabled}
taskId={taskId}
onInsertChip={insertChip}
onAttachFiles={onAttachFiles}
Expand Down
6 changes: 5 additions & 1 deletion apps/array/src/renderer/features/message-editor/tiptap/useTiptapEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface UseTiptapEditorOptions {
taskId?: string;
placeholder?: string;
disabled?: boolean;
isLoading?: boolean;
isCloud?: boolean;
autoFocus?: boolean;
context?: DraftContext;
Expand All @@ -35,6 +36,7 @@ export function useTiptapEditor(options: UseTiptapEditorOptions) {
taskId,
placeholder = "",
disabled = false,
isLoading = false,
isCloud = false,
autoFocus = false,
context,
Expand Down Expand Up @@ -97,6 +99,7 @@ export function useTiptapEditor(options: UseTiptapEditorOptions) {
attributes: { class: EDITOR_CLASS },
handleKeyDown: (view, event) => {
if (event.key === "Enter" && !event.shiftKey) {
if (!view.editable) return false;
const suggestionPopup = document.querySelector("[data-tippy-root]");
if (suggestionPopup) return false;
event.preventDefault();
Expand Down Expand Up @@ -217,6 +220,7 @@ export function useTiptapEditor(options: UseTiptapEditorOptions) {

const submit = useCallback(() => {
if (!editor) return;
if (disabled || isLoading) return;

const text = editor.getText().trim();
if (!text) return;
Expand All @@ -236,7 +240,7 @@ export function useTiptapEditor(options: UseTiptapEditorOptions) {
editor.commands.clearContent();
prevBashModeRef.current = false;
draft.clearDraft();
}, [editor, isCloud, draft]);
}, [editor, disabled, isLoading, isCloud, draft]);

submitRef.current = submit;

Expand Down
16 changes: 7 additions & 9 deletions apps/array/src/renderer/features/task-detail/components/TaskInputEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export const TaskInputEditor = forwardRef<
const isWorktreeMode = localWorkspaceMode === "worktree";
const isCloudMode = runMode === "cloud";
const { isOnline } = useConnectivity();
const isDisabled = isCreatingTask || !isOnline;

useHotkeys(
"shift+tab",
Expand Down Expand Up @@ -82,7 +83,8 @@ export const TaskInputEditor = forwardRef<
} = useTiptapEditor({
sessionId,
placeholder: "What do you want to work on? - @ to add context",
disabled: isCreatingTask,
disabled: isDisabled,
isLoading: isCreatingTask,
isCloud: isCloudMode,
autoFocus: true,
context: { repoPath },
Expand Down Expand Up @@ -198,7 +200,7 @@ export const TaskInputEditor = forwardRef<

<Flex justify="between" align="center" px="3" pb="3">
<EditorToolbar
disabled={isCreatingTask}
disabled={isDisabled}
onInsertChip={insertChip}
attachTooltip="Attach files from anywhere"
iconSize={16}
Expand Down Expand Up @@ -241,17 +243,13 @@ export const TaskInputEditor = forwardRef<
e.stopPropagation();
onSubmit();
}}
disabled={!canSubmit || isCreatingTask}
disabled={!canSubmit || isDisabled}
loading={isCreatingTask}
style={{
backgroundColor:
!canSubmit || isCreatingTask
? "var(--accent-a4)"
: undefined,
!canSubmit || isDisabled ? "var(--accent-a4)" : undefined,
color:
!canSubmit || isCreatingTask
? "var(--accent-8)"
: undefined,
!canSubmit || isDisabled ? "var(--accent-8)" : undefined,
}}
>
<ArrowUp size={16} weight="bold" />
Expand Down