Skip to content

fix: Skip protocol registration in development to avoid hijacking deep links #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanlab merged 1 commit into from
Jan 13, 2026
+9 −10
Merged

fix: Skip protocol registration in development to avoid hijacking deep links #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions apps/array/src/main/services/deep-link/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,18 @@ export class DeepLinkService {
return;
}

// Register the protocol
// Skip protocol registration in development to avoid hijacking deep links
// from the production app. OAuth uses HTTP callback in dev mode anyway.
if (process.defaultApp) {
// Development: need to register with path to electron
if (process.argv.length >= 2) {
app.setAsDefaultProtocolClient(PROTOCOL, process.execPath, [
process.argv[1],
]);
}
} else {
// Production
app.setAsDefaultProtocolClient(PROTOCOL);
log.info(
"Skipping protocol registration in development (using HTTP callback for OAuth)",
);
return;
}

// Production: register the protocol
app.setAsDefaultProtocolClient(PROTOCOL);

this.protocolRegistered = true;
log.info(`Registered '${PROTOCOL}' protocol handler`);
}
Expand Down