Skip to content

fix: Plan is stale only if a turn-ending response came after it #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanlab merged 1 commit into from
Jan 13, 2026
Merged

fix: Plan is stale only if a turn-ending response came after it #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions apps/array/src/renderer/features/sessions/components/SessionView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,20 @@ export function SessionView({
const latestPlan = useMemo((): Plan | null => {
let planIndex = -1;
let plan: Plan | null = null;
let responseIndex = -1;
let turnEndResponseIndex = -1;

// Find the most recent plan and response in one pass
// Find the most recent plan and turn-ending response in one pass
for (let i = events.length - 1; i >= 0; i--) {
const msg = events[i].message;

if (responseIndex === -1 && isJsonRpcResponse(msg)) {
responseIndex = i;
// Only consider responses that end a turn (session/prompt responses have stopReason)
// Other responses (like tool completions) should not invalidate the plan
if (
turnEndResponseIndex === -1 &&
isJsonRpcResponse(msg) &&
(msg.result as { stopReason?: string })?.stopReason !== undefined
) {
turnEndResponseIndex = i;
}

if (
Expand All @@ -127,11 +133,11 @@ export function SessionView({
}
}

if (planIndex !== -1 && responseIndex !== -1) break;
if (planIndex !== -1 && turnEndResponseIndex !== -1) break;
}

// Plan is stale if the most recent response came after it (turn completed)
if (responseIndex > planIndex) return null;
// Plan is stale only if a turn-ending response came after it
if (turnEndResponseIndex > planIndex) return null;

return plan;
}, [events]);
Expand Down