Skip to content

Always show panel icons #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanlab merged 1 commit into from
Jan 9, 2026
Merged

Always show panel icons #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/array/src/renderer/features/panels/components/LeafNodeRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ interface LeafNodeRendererProps {
draggingTabPanelId: string | null;
onActiveTabChange: (panelId: string, tabId: string) => void;
onPanelFocus: (panelId: string) => void;
focusedPanelId: string | null;
onAddTerminal: (panelId: string) => void;
onSplitPanel: (panelId: string, direction: SplitDirection) => void;
}
Expand All @@ -34,7 +33,6 @@ export const LeafNodeRenderer: React.FC<LeafNodeRendererProps> = ({
draggingTabPanelId,
onActiveTabChange,
onPanelFocus,
focusedPanelId,
onAddTerminal,
onSplitPanel,
}) => {
Expand Down Expand Up @@ -62,7 +60,6 @@ export const LeafNodeRenderer: React.FC<LeafNodeRendererProps> = ({
onPanelFocus={onPanelFocus}
draggingTabId={draggingTabId}
draggingTabPanelId={draggingTabPanelId}
isFocused={focusedPanelId === node.id}
onAddTerminal={() => onAddTerminal(node.id)}
onSplitPanel={(direction) => onSplitPanel(node.id, direction)}
/>
Expand Down
1 change: 0 additions & 1 deletion apps/array/src/renderer/features/panels/components/PanelLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ const PanelLayoutRenderer: React.FC<{
draggingTabPanelId={layoutState.draggingTabPanelId}
onActiveTabChange={handleSetActiveTab}
onPanelFocus={handlePanelFocus}
focusedPanelId={layoutState.focusedPanelId}
onAddTerminal={handleAddTerminal}
onSplitPanel={handleSplitPanel}
/>
Expand Down
59 changes: 26 additions & 33 deletions apps/array/src/renderer/features/panels/components/TabbedPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ interface TabbedPanelProps {
onPanelFocus?: (panelId: string) => void;
draggingTabId?: string | null;
draggingTabPanelId?: string | null;
isFocused?: boolean;
onAddTerminal?: () => void;
onSplitPanel?: (direction: SplitDirection) => void;
}
Expand All @@ -68,7 +67,6 @@ export const TabbedPanel: React.FC<TabbedPanelProps> = ({
onPanelFocus,
draggingTabId = null,
draggingTabPanelId = null,
isFocused = false,
onAddTerminal,
onSplitPanel,
}) => {
Expand Down Expand Up @@ -193,37 +191,32 @@ export const TabbedPanel: React.FC<TabbedPanelProps> = ({
/>
)}
</Flex>
{isFocused &&
content.droppable &&
(onSplitPanel || onAddTerminal) && (
<Flex
style={{
position: "absolute",
right: 0,
top: 0,
height: "32px",
borderLeft: "1px solid var(--gray-6)",
background: "var(--color-background)",
}}
>
{onSplitPanel && (
<TabBarButton
ariaLabel="Split panel"
onClick={handleSplitClick}
>
<SquareSplitHorizontalIcon width={12} height={12} />
</TabBarButton>
)}
{onAddTerminal && (
<TabBarButton
ariaLabel="Add terminal"
onClick={onAddTerminal}
>
<PlusIcon width={12} height={12} />
</TabBarButton>
)}
</Flex>
)}
{content.droppable && (onSplitPanel || onAddTerminal) && (
<Flex
style={{
position: "absolute",
right: 0,
top: 0,
height: "32px",
borderLeft: "1px solid var(--gray-6)",
background: "var(--color-background)",
}}
>
{onSplitPanel && (
<TabBarButton
ariaLabel="Split panel"
onClick={handleSplitClick}
>
<SquareSplitHorizontalIcon width={12} height={12} />
</TabBarButton>
)}
{onAddTerminal && (
<TabBarButton ariaLabel="Add terminal" onClick={onAddTerminal}>
<PlusIcon width={12} height={12} />
</TabBarButton>
)}
</Flex>
)}
</Box>
)}

Expand Down
Loading