fix: add azure auth related env into secrets#201
Open
b4s36t4 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Helm charts’ Azure log storage configuration to support Azure Entra (service principal) authentication by adding the required environment variables, wiring them into gateway Secrets/env injection, and documenting the new options.
Changes:
- Add
AZURE_ENTRA_CLIENT_ID,AZURE_ENTRA_CLIENT_SECRET, andAZURE_ENTRA_TENANT_IDto values for bothportkey-gatewayandportkey-app. - Include the new Azure Entra variables in the gateway Secret template and env var injection (portkey-app).
- Update configuration documentation to describe Azure auth modes and the Entra-specific settings.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Adds Azure Entra env keys under environment.data. |
| charts/portkey-gateway/templates/_helpers.tpl | Extends the log store env allowlist to include Azure Entra-related keys. |
| charts/portkey-gateway/docs/Configuration.md | Documents Azure auth modes and Entra configuration variables. |
| charts/portkey-app/values.yaml | Adds Azure Entra keys under logStorage.azure. |
| charts/portkey-app/templates/gateway/secrets.yaml | Stores Azure Entra values in the gateway Secret. |
| charts/portkey-app/templates/_helpers.tpl | Exposes Azure Entra values to the gateway container via secretKeyRef. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.