Fix/logstore existing secret#200
Open
avaya09 wants to merge 4 commits into
Open
Conversation
added 4 commits
May 20, 2026 16:08
- Added support for using an existing Kubernetes Secret for log storage credentials in values.yaml. - Updated secret management in templates to reference the new log storage secret. - Expanded documentation to include expected keys for various log storage backends.
…tes Secret - Introduced configuration options for reusing an existing Kubernetes Secret for bedrockAssumed credentials in values.yaml. - Updated documentation to reflect the new secret management for bedrockAssumed. - Enhanced templates to conditionally reference the existing secret for bedrockAssumed credentials.
- Modified the conditional logic in secrets.yaml to ensure proper handling of existing secrets for both log storage and bedrockAssumed credentials. - This change enhances the flexibility of secret management in the gateway configuration.
- Changed the logStore value from s3Compat to s3_custom in openshift.yaml to reflect the new naming convention. - Updated documentation to clarify the available logStore options, including the addition of s3_custom.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support in the portkey-app Helm chart to reference pre-existing Kubernetes Secrets for log storage credentials (and optionally for bedrockAssumed credentials), instead of always requiring the chart to generate/manage those credentials in a chart-created Secret.
Changes:
- Added
logStorage.existingSecretNameandbedrockAssumed.existingSecretNamevalues to allow reusing externally managed Secrets. - Updated Secret generation and env var secret references to conditionally use either the chart-managed Secret or the provided existing Secret(s).
- Expanded
docs/secret-manager-integration.mdwith examples and a key-mapping table for required Secret keys per backend.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/portkey-app/values.yaml | Introduces existingSecretName knobs for log storage and bedrockAssumed credential sourcing. |
| charts/portkey-app/templates/gateway/secrets.yaml | Conditionally renders the chart-managed Secret only when needed (and only includes the relevant data sections). |
| charts/portkey-app/templates/_helpers.tpl | Adds helper functions to resolve the Secret names and updates env var refs to use them. |
| charts/portkey-app/docs/secret-manager-integration.md | Documents how to sync/provide the required keys in external Secrets and how to configure the chart to use them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.