fix: use fullname helper for resource-config ConfigMap name#182
Draft
camjay wants to merge 1 commit intoPortkey-AI:mainfrom
Draft
fix: use fullname helper for resource-config ConfigMap name#182camjay wants to merge 1 commit intoPortkey-AI:mainfrom
camjay wants to merge 1 commit intoPortkey-AI:mainfrom
Conversation
27fb98c to
756a918
Compare
The resource-config ConfigMap uses a hardcoded name instead of the portkeyenterprise.fullname helper. This causes a name collision when deploying multiple chart instances in the same namespace — all instances try to own the same ConfigMap, causing ArgoCD sync conflicts. - Prefix name with portkeyenterprise.fullname (consistent with all other resources in the chart) - Add standard chart labels via portkeyenterprise.labels - Update values.yaml comment and README to reflect dynamic naming
756a918 to
8e416de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
resource-configConfigMap incharts/portkey-gateway/templates/resources-config.yamluses a hardcodedname: resource-configinstead of theportkeyenterprise.fullnametemplate helper. This causes a name collision when deploying multiple instances of the chart in the same Kubernetes namespace — all instances attempt to own the same ConfigMap, resulting in sync conflicts (e.g., in ArgoCD or Flux).Every other resource in the chart already uses the fullname helper for its metadata name. This ConfigMap is the only one that doesn't.
Changes
templates/resources-config.yaml: Prefix name with{{ include "portkeyenterprise.fullname" . }}and add standardportkeyenterprise.labelsvalues.yaml: Update commented volume example to reflect dynamic namingREADME.md: Update PEM volume mounting example to reflect dynamic namingValidation
Verified with
helm templateusing multiple release names andfullnameOverridevalues:helm lintpasses with no warnings.Breaking Change
This renames an existing Kubernetes resource. On upgrade, the ConfigMap name changes from
resource-configto<fullname>-resource-config. Two things to be aware of:Volume mounts: If the commented-out volume mount in
values.yamlhas been enabled,volumes[].configMap.namemust be updated to match the new dynamic name. For most deployments this volume is commented out by default and no action is needed.Orphaned ConfigMap: After upgrading, the old
resource-configConfigMap will remain in the namespace.helm upgradedoes not delete renamed resources. Users should clean it up manually:ArgoCD deployments with
prune: truewill handle this automatically.Version bump: This breaking change should be included in a minor or major version bump per semver conventions. Suggesting it be picked up in the next chart release.