Open
Conversation
Fixes PolymerElements#24 by exposing the highlighter functionality to data-binding and programatic use. Also now checks that the host exists before dealing with event listeners.
Contributor
|
Thanks for the PR @43081j! I believe |
Contributor
Author
|
@FredKSchott true although I'd say it still does. we're simply exposing what our event firing already does but through data-binding so it can work in dom-repeats and such (templates). I haven't really added anything beyond exposing what we already have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24 by exposing the highlighter functionality to data-binding and
programatic use.
Also now checks that the host exists before dealing with event listeners.
I have left
_highlightnamed as it is for backwards-compatibility as some people may still be calling it directly.