Fixed heap out of memory on network issues#39
Open
aizo231 wants to merge 3 commits into
Open
Conversation
Heap out of memory error happened, because WebSocket instance was not terminated when establishing new one, leading to massive spike in memory on network errors.
I could seperate it into two commits right?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heap out of memory error happened, because WebSocket instance was not terminated when establishing new one, leading to massive spike in memory on network errors.
Note
Medium Risk
Changes WebSocket lifecycle/reconnect behavior by terminating and nulling sockets on
error/close, which could affect reconnect timing and any downstream assumptions aboutwsbeing non-null.Overview
Improves
RealTimeDataClientresilience to network failures by explicitly cleaning up WebSocket instances onerrorandclose(remove listeners,terminate(), and clearws) before attempting auto-reconnect, preventing buildup of orphaned sockets and memory growth.Adds guards so
ping()and thepong-driven ping loop only run when a socket exists, and ensuresDISCONNECTEDstatus is emitted on errors as well as closes.Written by Cursor Bugbot for commit 01d1d6e. This will update automatically on new commits. Configure here.