Drop unsupported tag/series request params and response fields#64
Open
naruto11eth wants to merge 2 commits into
Open
Drop unsupported tag/series request params and response fields#64naruto11eth wants to merge 2 commits into
naruto11eth wants to merge 2 commits into
Conversation
`include_chat` (tags + series), `categories_ids` and `categories_labels` (series) are accepted but never bound upstream. Remove them from `get_tag`, `list_tags`, `get_series` and `list_series` across the sync and async clients, and narrow the tag slug-guard to `include_template`. `include_template` and the events `include_chat` stay (real params).
Drop `Tag.chats`, `Series.categories` and `Series.chats` — never populated upstream. Casing is unchanged: public attrs are already `tag_id`/`related_tag_id` and the `validation_alias` keeps reading the upstream `tagID` wire key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes tag/series request params (
include_chat,categories_ids,categories_labels) the clients accept but the upstream never binds, and response fields (Tag.chats,Series.categories,Series.chats) it never populates — across the sync and async clients.include_templateand the eventsinclude_chatare real and retained (the tag slug-guard is narrowed accordingly). Response casing is unchanged — the public attrs are alreadytag_id/related_tag_idand thevalidation_aliaskeeps reading the upstreamtagIDwire key.Note
Medium Risk
Breaking public API removals across four client modules; low runtime risk since removed options were ineffective upstream, but integrators must update call sites.
Overview
Removes gamma tag/series API surface that the upstream does not support, across internal specs, sync/async public and secure clients, and Pydantic models.
Request parameters dropped:
include_chatonget_series,get_tag,list_series, andlist_tags;categories_idsandcategories_labelsonlist_series. Eventinclude_chat(get/list events) is unchanged.include_templatestays on tag endpoints; slug lookup now only rejectsinclude_template(notinclude_chat).Response fields removed:
Series.categories,Series.chats, andTag.chats. Unit tests for specs and models are updated accordingly.This is a breaking change for callers passing the removed kwargs or reading the removed attributes.
Reviewed by Cursor Bugbot for commit 24ff6f9. Bugbot is set up for automated code reviews on this repo. Configure here.