add error context to ctf contract calls#77
Closed
notyrjo wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three contract read calls in
ctf.rs(getConditionId,getCollectionId,getPositionId) propagate errors with?but without context, so when they fail the user sees a raw RPC or transport error with no indication of which operation failed.This adds
.context()messages consistent with the error handling pattern used elsewhere in the codebase.Note
Low Risk
Read-only CLI error messaging only; no behavior, auth, or on-chain logic changes.
Overview
Adds
anyhow::Contextmessages on the three read-only CTF contract calls inctf.rs(getConditionId,getCollectionId,getPositionId) so RPC/transport failures name the operation instead of surfacing a bare error.This matches the existing pattern on write paths (e.g. "Split position failed") and on input parsing in the same file.
Reviewed by Cursor Bugbot for commit 3baa0d4. Bugbot is set up for automated code reviews on this repo. Configure here.