Optimise white noise/Frequency RFC (input wanted) #6
+160
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains a more optimal implementation of white noise, which
I also am of the opinion that Frequency in general should be pulled out into its own sampler, as there is a ton of duplicated logic and weird edgecases surrounding frequency in the sampler code (like this white noise thing). If frequency was its own sampler, like FBM, the codebase would be much cleaner. I have not implemented that change in this PR, as it would be an extensive change to all the sampler code, so I would like input on that before I do it.