Hotfix/various fixes scope regression#24
Draft
Pollux12 wants to merge 28 commits into
Draft
Conversation
Not sure on the best way to really solve this, I think it's reasonable to assume that the base args for the wiki defined things aren't going to be changed / overridden, so we should instead merge or should meta version where possible for things like hover or type info
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removes old flow budget stuff that can cause issues with large files
Caches scripted scope scanning once per workspace
Cache and re-use function call infer data
This reduces a lot of noise false positives, but also can reduce the strictness of types. Default on, can be toggled off.
Precomputes workspace-wide facts so common diagnostics can skip full-tree scans when nothing relevant can fire. Shares the same candidate lists and prefix events across checkers instead of rebuilding them per file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes call, export, and generic mismatch checks. Fixes various exact field lookups as well.
Preserve metatable instances and table-backed aliases when resolving dynamic fields. Keeps hover, definition, completion, and diagnostics on the inferred override from the original annotated version, while also allowing for changes in parameters etc... Could cause some false positives where heavy overrides are used, with the shape being changed completely, although I doubt many are completely changing base gmod functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various issues