Remove reported SPM data inputs#960
Merged
Merged
Conversation
103fdab to
a7f6204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_data, and calibrate SNAP loss against canonicalsnapDependency
Depends on PolicyEngine/policyengine-us#8263 for the new
spm_unit_capped_housing_subsidy_dataandspm_unit_energy_subsidy_datavariables and removal of the old reported public variables.GitHub
unit-testsare expected to fail while CI installs releasedpolicyengine-uswithout those variables; local validation passes with #8263 installed editable. After #8263 is merged and released, this PR should bump the dependency/lock to that release and rerun CI.Tests
uv run --no-sync ruff check policyengine_us_data/datasets/cps/cps.py policyengine_us_data/datasets/cps/extended_cps.py policyengine_us_data/utils/loss.py policyengine_us_data/db/etl_national_targets.py policyengine_us_data/utils/national_target_parity.py tests/integration/support/tiny_stage_3.py tests/integration/test_cps_generation.py tests/unit/datasets/test_cps_file_handles.py tests/unit/test_etl_national_targets.pyuv run --no-sync pytest tests/unit/test_extended_cps.py tests/unit/test_etl_national_targets.py tests/unit/test_state_fips.py tests/integration/test_cps_generation.py tests/unit/datasets/test_cps_file_handles.py tests/integration/test_tiny_stage_3_artifacts.py tests/integration/test_tiny_stage_4_artifacts.py -qspm_unit_broadband_subsidy,spm_unit_broadband_subsidy_reported, andsnap_reportedabsent;spm_unit_capped_housing_subsidy_data,spm_unit_energy_subsidy_data,acp, andebbpresent