Skip to content

Remove reported SPM data inputs#960

Merged
MaxGhenis merged 2 commits into
mainfrom
codex/remove-reported-spm-inputs
May 12, 2026
Merged

Remove reported SPM data inputs#960
MaxGhenis merged 2 commits into
mainfrom
codex/remove-reported-spm-inputs

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

@MaxGhenis MaxGhenis commented May 12, 2026

Summary

  • stop exporting reported WIC, school meals, broadband, and SPM tax inputs from CPS outputs
  • keep SNAP/SSI reported values only as build-time take-up anchors and drop them before saving
  • rename data-backed housing and energy subsidy leaves to *_data, and calibrate SNAP loss against canonical snap

Dependency

Depends on PolicyEngine/policyengine-us#8263 for the new spm_unit_capped_housing_subsidy_data and spm_unit_energy_subsidy_data variables and removal of the old reported public variables.

GitHub unit-tests are expected to fail while CI installs released policyengine-us without those variables; local validation passes with #8263 installed editable. After #8263 is merged and released, this PR should bump the dependency/lock to that release and rerun CI.

Tests

  • uv run --no-sync ruff check policyengine_us_data/datasets/cps/cps.py policyengine_us_data/datasets/cps/extended_cps.py policyengine_us_data/utils/loss.py policyengine_us_data/db/etl_national_targets.py policyengine_us_data/utils/national_target_parity.py tests/integration/support/tiny_stage_3.py tests/integration/test_cps_generation.py tests/unit/datasets/test_cps_file_handles.py tests/unit/test_etl_national_targets.py
  • uv run --no-sync pytest tests/unit/test_extended_cps.py tests/unit/test_etl_national_targets.py tests/unit/test_state_fips.py tests/integration/test_cps_generation.py tests/unit/datasets/test_cps_file_handles.py tests/integration/test_tiny_stage_3_artifacts.py tests/integration/test_tiny_stage_4_artifacts.py -q
  • registry check with local #8263 installed: spm_unit_broadband_subsidy, spm_unit_broadband_subsidy_reported, and snap_reported absent; spm_unit_capped_housing_subsidy_data, spm_unit_energy_subsidy_data, acp, and ebb present

@MaxGhenis MaxGhenis force-pushed the codex/remove-reported-spm-inputs branch from 103fdab to a7f6204 Compare May 12, 2026 16:59
@MaxGhenis MaxGhenis marked this pull request as ready for review May 12, 2026 16:59
@MaxGhenis MaxGhenis merged commit e0be63b into main May 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant