chore: Remove deprecated GCP simulation API code #3102
+80
−681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3102 +/- ##
==========================================
- Coverage 70.73% 70.53% -0.20%
==========================================
Files 57 55 -2
Lines 2443 2386 -57
Branches 341 339 -2
==========================================
- Hits 1728 1683 -45
+ Misses 654 642 -12
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Delete GCP Workflows simulation client (simulation_api.py) - Remove simulation API factory pattern, use Modal API directly - Remove google-cloud-workflows dependency from setup.py - Clean up GCP-related constants from constants.py - Update economy_service to import simulation_api_modal directly - Delete deprecated GCP Workflows script (request-simulation-model-versions.sh) - Remove factory-related test fixtures and unit tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add changelog entry for GCP simulation API removal - Add MOCK_EXECUTION_ID alias in test fixtures for compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Apply black formatting - Add trailing newlines to __init__.py files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace GCP-style status values (SUCCEEDED, FAILED, ACTIVE) with Modal-style values (complete, failed, running) in economy service tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
anth-volk
force-pushed
the
chore/remove-deprecated-gcp-code
branch
from
53d6692 to
af95d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3101
Summary
Removes deprecated GCP-related simulation API code following the migration of simulation workloads to Modal and the sunset of GCP infrastructure.
Changes
Deleted Files
policyengine_api/libs/simulation_api.py- Old GCP Workflows clientpolicyengine_api/libs/simulation_api_factory.py- Factory pattern for switching between GCP/Modal.github/request-simulation-model-versions.sh- GCP Workflows execution script referencing defunct projecttests/unit/libs/test_simulation_api_factory.py- Factory unit teststests/fixtures/libs/simulation_api_factory.py- Factory test fixturesModified Files
policyengine_api/services/economy_service.py- Now importssimulation_api_modaldirectly instead of using factorypolicyengine_api/libs/simulation_api_modal.py- Updated docstrings to remove GCP referencespolicyengine_api/constants.py- Removed GCP execution status constants (kept Modal-only)setup.py- Removedgoogle-cloud-workflowsdependencytests/fixtures/services/economy_service.py- Already Modal-only, no changes neededTest plan
🤖 Generated with Claude Code