feat: add matricole intro#111
Conversation
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughAdds a typed /matricole Next.js page (metadata + MatricolePage), a MatricoleIntro section rendering resource CardIcon cards, tweaks FAQs container to use section, updates header and Hero navigation to link to /matricole, and extends CardIcon with a compact size and align prop. ChangesMatricole Page Feature
Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/matricole/intro.tsx (1)
29-46: ⚡ Quick winClarify whether ResourceCard should link to destination pages.
The cards display action-oriented descriptions ("Controlla i risultati...", "Tutte le informazioni..."), but currently render as static display components. Header navigation has corresponding items ("Rankings", "Tol Project") pointing to placeholder hrefs, and no destination routes exist yet. Consider either: (1) wrapping cards with links once routes are implemented, or (2) clarifying if these should remain informational only.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/matricole/intro.tsx` around lines 29 - 46, ResourceCard is currently a static display but uses action-oriented copy; decide whether it should navigate or stay informational and implement accordingly: add an optional href?: string to ResourceCardProps and, inside ResourceCard, conditionally wrap the Glass component with a Next.js <Link> (or an <a> for non-Next projects) when href is provided, preserving className and accessibility (use role/aria as needed, target/rel for external links); alternatively, if you intend it to remain informational, update the copy passed to title/description to remove imperative phrasing. Update all callers of ResourceCard to pass href when navigation is desired (e.g., for "Rankings" / "Tol Project") or change the copy where no route exists.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/matricole/intro.tsx`:
- Around line 48-123: The MatricoleBackground component currently uses a fixed
viewport-width-dependent height (h-[248.3218vw]) and hardcoded style percentages
(e.g., left: "-26.0417%", left: "66.7244%", top: "-10.1142%") which break
responsiveness; update MatricoleBackground to use responsive sizing (replace
h-[248.3218vw] and the inline percentage style values with Tailwind responsive
utilities like sm:, md:, lg: variants or switch to CSS variables/clamp() or
media-query-driven classes), adjust the Image wrapper positioning to provide
alternative values per breakpoint (for the two Image instances and the two
positioned looper containers), and verify visually across mobile/tablet/desktop
to ensure the background scales as intended without overflowing layout.
---
Nitpick comments:
In `@src/components/matricole/intro.tsx`:
- Around line 29-46: ResourceCard is currently a static display but uses
action-oriented copy; decide whether it should navigate or stay informational
and implement accordingly: add an optional href?: string to ResourceCardProps
and, inside ResourceCard, conditionally wrap the Glass component with a Next.js
<Link> (or an <a> for non-Next projects) when href is provided, preserving
className and accessibility (use role/aria as needed, target/rel for external
links); alternatively, if you intend it to remain informational, update the copy
passed to title/description to remove imperative phrasing. Update all callers of
ResourceCard to pass href when navigation is desired (e.g., for "Rankings" /
"Tol Project") or change the copy where no route exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 23ca5553-f7d3-441b-ba0a-1f7eb129c707
📒 Files selected for processing (4)
src/app/matricole/page.tsxsrc/components/header/constants.tssrc/components/home/hero.tsxsrc/components/matricole/intro.tsx
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com> # Conflicts: # src/app/matricole/page.tsx
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/matricole/faqs.tsx (1)
40-40: ⚡ Quick winConsider removing
min-h-screenfrom the FAQ section.The
min-h-screenutility forces this section to take at least the full viewport height, which may create excessive whitespace when the FAQ content is short (currently 5 items). Since this section is rendered belowMatricoleIntrowithin the page, users will need to scroll past potentially empty space.Consider removing
min-h-screenor replacing it with a more moderate minimum height to improve the user experience.♻️ Proposed fix to adjust section height
- <section className="mx-auto flex min-h-screen w-full max-w-400 flex-col items-center justify-center gap-16 px-9 py-49 sm:gap-20"> + <section className="mx-auto flex w-full max-w-400 flex-col items-center justify-center gap-16 px-9 py-49 sm:gap-20">🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/matricole/faqs.tsx` at line 40, The FAQ section currently forces a full viewport height via the class "min-h-screen" in the section element inside the Matricole FAQs component; remove "min-h-screen" (or replace it with a more moderate utility such as "min-h-0" or a specific smaller min-height utility) in the className on the section element in src/components/matricole/faqs.tsx so the section only takes the space needed and avoids large empty whitespace below MatricoleIntro.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/matricole/faqs.tsx`:
- Line 40: The FAQ section currently forces a full viewport height via the class
"min-h-screen" in the section element inside the Matricole FAQs component;
remove "min-h-screen" (or replace it with a more moderate utility such as
"min-h-0" or a specific smaller min-height utility) in the className on the
section element in src/components/matricole/faqs.tsx so the section only takes
the space needed and avoids large empty whitespace below MatricoleIntro.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 041f4cb7-8bdb-4814-8f68-9ec2d5f52238
📒 Files selected for processing (3)
src/app/matricole/page.tsxsrc/components/home/hero.tsxsrc/components/matricole/faqs.tsx
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
2 participants
fixes #95