Open
Conversation
Collaborator
|
rebase |
Dalton-V
force-pushed
the
frlg-lucky-egg-farmer
branch
from
6b66ed5 to
fa3e140
Compare
Mysticial
reviewed
Apr 13, 2026
| Language::Italian, | ||
| Language::Korean, | ||
| Language::ChineseSimplified, | ||
| Language::ChineseTraditional, |
Collaborator
There was a problem hiding this comment.
Same as the other PR. Are all these languages available?
Collaborator
|
I haven't reviewed the actual Lucky Egg file yet. But all the detectors are fine if you want to pull those out into a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Lucky Egg Farmer for FRLG
This program is dependent on the WildEncounterReader in #1135
New Detectors
PartyHeldItemDetectorused to detect if a captured Chansey is holding a Lucky EggBattleSelectionArrowDetectorthe selection arrow in battles is slightly different from the start menu arrow. This new arrow is also used when asked for a nickname.PokedexRegisteredDetectorthis detects the "A" button in the bottom right when a new pokemon is added to the dex. (Used if the player has not captured Chansey before.Updates to existing logic