Add all Colosseum Pokemon to API

[notblisy]

This commit seeks to add all the Pokemon obtainable from Pokemon Colosseum.

• 48 Regular Shadow Pokemon
• 4 gift Pokemon (Ho-Oh, Plusle, Espeon, Umbreon)
• 3 E-Reader JPN Only Shadow Pokemon

I referenced everything from these bulbapedia lists:

https://bulbapedia.bulbagarden.net/wiki/List_of_Shadow_Pok%C3%A9mon

https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_Colosseum

I added 2 new capture methods:
-Snag
-Snag-rematch

Encounters in Colosseum are a bit weird. They're trainer battles where you steal Pokemon. For a lot of them, if you KO the Pokemon and continue the story, you can find them again in a separate location. Those new locations are tagged as "rematch" to indicate to players you cannot find them in those spots right away.

[notblisy]

I'm not sure why this failed, but I'll check in an hour or two. I must have a dupe somewhere or something?

[jemarq04]

I'm not sure why this failed, but I'll check in an hour or two. I must have a dupe somewhere or something?

From a quick check, I think you have a location area id of 1268 somewhere that doesn't map to a valid location area.

[jemarq04]

Thanks again for your contributions! It's good to see Colosseum and XD start getting some love in the API. I'm not familiar with these games as much, so I'm trusting you on the specific location area names that Bulbapedia does not mention. I've left a few comments/suggestions on the code, and I have a couple comments that didn't fit with any specific line:

• It looks like snag-rematch encounters are missing for Bayleef, Croconaw, and Quilava in Realgam Tower.
• On Bulbapedia, Realgam Tower Dome and Realgam Tower are separated and I see here that all encounters in the dome were put in the default location area along with the only Realgam Tower encounter listed. Was this intentional?

Finally, separate from the PR itself, I noticed that the API refers to Pyrite Town as pyrite-city. This is slightly outside the scope of the PR, so maybe another maintainer may want it separate, but this is something we should change in the future.

[notblisy]

Thanks again for your contributions! It's good to see Colosseum and XD start getting some love in the API. I'm not familiar with these games as much, so I'm trusting you on the specific location area names that Bulbapedia does not mention. I've left a few comments/suggestions on the code, and I have a couple comments that didn't fit with any specific line:

* It looks like `snag-rematch` encounters are missing for Bayleef, Croconaw, and Quilava in Realgam Tower.

* On Bulbapedia, Realgam Tower Dome and Realgam Tower are separated and I see here that all encounters in the dome were put in the default location area along with the only Realgam Tower encounter listed. Was this intentional?

Finally, separate from the PR itself, I noticed that the API refers to Pyrite Town as pyrite-city. This is slightly outside the scope of the PR, so maybe another maintainer may want it separate, but this is something we should change in the future.

There are no realgam tower matches for these Pokemon. The trainers who had them show up based on which of the starters you initially picked, but will never have them.

Realgam tower dome isn't really a location. I'm not sure what bulbapedia means by this. It's basically 2 floors and then the colosseum. Looking at the layout on bulbapedia, I think they're trying to say the domes are each individual areas. But they're all on 1f of the tower, and I don't think adding each dome in would be more helpful/descriptive.

Edit: I'll also rename pyrite city to pyrite town. I initially copied a table from serebii which had the incorrect name. The in-game english map location calls it pyrite town.

[jemarq04]

There are no realgam tower matches for these Pokemon. The trainers who had them show up based on which of the starters you initially picked, but will never have them.

Ah ok, thanks for checking!

Edit: I'll also rename pyrite city to pyrite town. I initially copied a table from serebii which had the incorrect name. The in-game english map location calls it pyrite town.

Looking again I see that Pyrite Town was added by you in this PR (I should've checked carefully lol) so thanks for reading through my silly comment about it and fixing that!

Looks like everything was addressed, I'll do a quick re-check soon.

[ItsMeJoji]

@notblisy If you have a chance, please consider adding the new location_area.csv information to location_area_prose.csv as well.

[jemarq04]

@notblisy If you have a chance, please consider adding the new location_area.csv information to location_area_prose.csv as well.

Missed this in both of your PRs 😭 That is a good catch!

Edit: Please do the same in location_names.csv and region_names.csv.

[ItsMeJoji]

@notblisy If you have a chance, please consider adding the new location_area.csv information to location_area_prose.csv as well.

Missed this in both of your PRs 😭 That is a good catch!

Edit: Please do the same in location_names.csv and region_names.csv.

Hahaha. All good. I remembered to add the Forest ones on my previous PR after it pointed it out on the Island PR.

[notblisy]

@notblisy If you have a chance, please consider adding the new location_area.csv information to location_area_prose.csv as well.

Missed this in both of your PRs 😭 That is a good catch!

Edit: Please do the same in location_names.csv and region_names.csv.

I think I got all this in correctly. I also realize I've got an unused location I think? The Under Colosseum has no encounters. I added it by accident and haven't removed it. But it is a game location that has NPCs and items so I don't think there's much harm?

Happy to change anything formatting related, I wasn't super sure what's going on with the location area prose parenthesis there isn't exactly a style guide.