ORAS Mirage Forest Encounters#1441
Conversation
I realized after creating this PR that the IDs in the encounter.csv were incorrect at the end of it.
Removed --break-system-packages option from install and dev-install commands. Usually need this for my own machine.
|
I'll take a look at this soon, but as for your question on encounter slots yes. From what I've seen, these have been re-used for encounters with the same properties and I do not think there are any unintended consequences for that. |
data/v2/csv/encounters.csv
Outdated
| 70914,25,1229,1350,431,36,38 | ||
| 70915,25,1229,1351,548,36,38 | ||
| 70916,26,1229,1348,114,36,38 | ||
| 70917,26,1229,1349,191,36,38 | ||
| 70918,26,1229,1350,431,36,38 |
There was a problem hiding this comment.
| 70914,25,1229,1350,431,36,38 | |
| 70915,25,1229,1351,548,36,38 | |
| 70916,26,1229,1348,114,36,38 | |
| 70917,26,1229,1349,191,36,38 | |
| 70918,26,1229,1350,431,36,38 | |
| 70914,25,1229,1350,432,36,38 | |
| 70915,25,1229,1351,548,36,38 | |
| 70916,26,1229,1348,114,36,38 | |
| 70917,26,1229,1349,191,36,38 | |
| 70918,26,1229,1350,432,36,38 |
Purugly is available here, not Glameow
data/v2/csv/encounters.csv
Outdated
| 70906,25,1228,1350,431,36,38 | ||
| 70907,25,1228,1351,37,36,38 | ||
| 70908,26,1228,1348,114,36,38 | ||
| 70909,26,1228,1349,191,36,38 | ||
| 70910,26,1228,1350,431,36,38 |
There was a problem hiding this comment.
| 70906,25,1228,1350,431,36,38 | |
| 70907,25,1228,1351,37,36,38 | |
| 70908,26,1228,1348,114,36,38 | |
| 70909,26,1228,1349,191,36,38 | |
| 70910,26,1228,1350,431,36,38 | |
| 70906,25,1228,1350,432,36,38 | |
| 70907,25,1228,1351,37,36,38 | |
| 70908,26,1228,1348,114,36,38 | |
| 70909,26,1228,1349,191,36,38 | |
| 70910,26,1228,1350,432,36,38 |
Purugly is available here, not Glameow
There was a problem hiding this comment.
Thanks for catching these!
|
Sorry this took so long @jemarq04 . Didn't realize the "commit suggestion" option did not apply when I tried it. pushed to my branch, so the changes should be there now. |
No worries! Looks good! |
|
Thank you both! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
4 participants
This PR includes additions for the missing Mirage Forest encounters for ORAS.
Luckily there's no Gen 3 equivalent for this and the last few Mirage Spots.
Also question about encounter slots, there's no harm in reusing them for multiple encounter types, correct? Just don't want to balloon that file with, in essence, duplicate entries.