Add more bugprone-* clang-tidy checks, Part B #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawme
force-pushed
the
norm.evangelista/add-further-bugprone-checks-part-b
branch
from
6e0167f to
c26c4c6
Compare
larshg
reviewed
Jan 17, 2026
larshg
reviewed
Jan 17, 2026
larshg
reviewed
Jan 17, 2026
mvieth
reviewed
Jan 24, 2026
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
I did not have a look at all the files yet, but here are already some comments.
In the cases where you introduced a dynamic_cast, I think it would be a good idea to check if the result is a nullptr before dereferencing it.
| (*label_image)[euclidean_label_index.indices[j]].r = 255; | ||
| (*label_image)[euclidean_label_index.indices[j]].g = 0; | ||
| (*label_image)[euclidean_label_index.indices[j]].b = 0; | ||
| for (int index : euclidean_label_index.indices) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int index : euclidean_label_index.indices) { | |
| for (const auto& index : euclidean_label_index.indices) { |
| for (const auto& region_index : region_indices) { | ||
| if (region_index.indices.size() > 1000) { | ||
| for (std::size_t j = 0; j < region_index.indices.size(); j++) { | ||
| for (int index : region_index.indices) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int index : region_index.indices) { | |
| for (const auto& index : region_index.indices) { |
| pcl::PointXYZ ground_pt((*cloud)[region_index.indices[j]].x, | ||
| (*cloud)[region_index.indices[j]].y, | ||
| (*cloud)[region_index.indices[j]].z); | ||
| for (int index : region_index.indices) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int index : region_index.indices) { | |
| for (const auto& index : region_index.indices) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate #6368, Part B including
appschanges to manage the size of the PR.Add 4 additional bugprone clang-tidy checks and applied fixes
bugprone-assert-side-effectbugprone-dangling-handlebugprone-forward-declaration-namespacebugprone-inaccurate-eraseSummary
These checks improve code safety and correctness by: